Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix link to Package Word Count from The Init File #86

Closed
wants to merge 1 commit into from

Conversation

rachelmyers
Copy link

Section 3.2: The Init File includes a link to Package: Word Count that didn't work for me; it defaulted back to the main docs page.

(My guess is that Package Word Count content used to be on the same page, and could use the shorthand for finding a section on the same page, <some-header>. Since then, it seems to have moved, so I think it needs to use the longer format, whatever_path[Text to Display].)

I've never written asciidoc before and was just passing through the Atom docs, so let me know if there's a better fix for this! 😁

@izuzak
Copy link
Contributor

izuzak commented Jul 2, 2015

It seems that most/all such links are now busted (for example, click the "Command Palette" link in the same article).

Those links were working pre-1.0, I belive. For example, visit https://atom.io/docs/v0.207.0/hacking-atom-the-init-file and click “Package: Word Count”. Maybe something broke on the server side when Atom went 1.0? cc @benogle @thedaniel

@rachelmyers
Copy link
Author

@izuzak Ah, I didn't try enough of the links to realize most of them were broken. Is the fix to manually update all the links? 😩

@izuzak
Copy link
Contributor

izuzak commented Jul 6, 2015

Is the fix to manually update all the links? 😩

I'm hoping 🙏 that's not the fix since those same links were working in the past. In other words, this doesn't seem like a problem in the links, but with how they are processed. Maybe @schacon has some 💡 on what's causing problems here.

@izuzak
Copy link
Contributor

izuzak commented Jul 16, 2015

The links are working again so I'm going to close this, @rachelmyers. Thanks for reporting this, though 🙇 -- @gjtorikian and I were looking into why this was happening and it definitely still happens in the docs for version 1.0.1 of Atom: https://atom.io/docs/v1.0.1/hacking-atom-the-init-file

I'll open a new issue so that we can track this and investigate further.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants