Port to Windows #7

zcbenz · 2013-10-18T12:43:32Z

This ports git-utils to Windows by using gyp to build libgit2, and fixes some wrong assumptions of path separator on Windows.

It's too cumbersome to setup all the building environments on Windows with the default cmake, using gyp would reduce to building requirements to minimum.

Port to Windows

mcolyer · 2013-10-25T20:05:14Z

I get the follow errors when building on Windows 8.1 with Visual Studio 2010 Express

error C2373: 'InterlockedIncrement': redefinition; different type modifiers
error C2373: 'InterlockedDecrement': redefinition; different type modifiers
error C2373: 'InterlockedExchangeAdd': redefinition; different type modifiers

zcbenz · 2013-10-28T01:51:29Z

Can you paste the detailed error message? I need to know from which file this error came from.

kevinsawicki · 2013-10-28T01:52:38Z

@zcbenz here is the output, looks like it occurs for three files for me:

  attr.c
C:\Program Files\Microsoft SDKs\Windows\v7.1\include\winbase.h(2288): error C2373: 'InterlockedIncrement' : redefinition; different type modifiers [C:\Users\kevin\Documents\GitHub\git-utils\build\libgit2.vcxproj]
C:\Program Files\Microsoft SDKs\Windows\v7.1\include\winbase.h(2295): error C2373: 'InterlockedDecrement' : redefinition; different type modifiers [C:\Users\kevin\Documents\GitHub\git-utils\build\libgit2.vcxproj]
C:\Program Files\Microsoft SDKs\Windows\v7.1\include\winbase.h(2314): error C2373: 'InterlockedExchangeAdd' : redefinition; different type modifiers [C:\Users\kevin\Documents\GitHub\git-utils\build\libgit2.vcxproj]
  checkout.c
  hashsig.c
  push.c
  Compiling...
  filter.c
  blob.c
  config_file.c
  fetch.c
  fetchhead.c
  reflog.c
  diff_patch.c
  stash.c
  fnmatch.c
  oid.c
  thread-utils.c
  delta.c
  pack-objects.c
  tsort.c
  remote.c
C:\Program Files\Microsoft SDKs\Windows\v7.1\include\winbase.h(2288): error C2373: 'InterlockedIncrement' : redefinition; different type modifiers [C:\Users\kevin\Documents\GitHub\git-utils\build\libgit2.vcxproj]
C:\Program Files\Microsoft SDKs\Windows\v7.1\include\winbase.h(2295): error C2373: 'InterlockedDecrement' : redefinition; different type modifiers [C:\Users\kevin\Documents\GitHub\git-utils\build\libgit2.vcxproj]
C:\Program Files\Microsoft SDKs\Windows\v7.1\include\winbase.h(2314): error C2373: 'InterlockedExchangeAdd' : redefinition; different type modifiers [C:\Users\kevin\Documents\GitHub\git-utils\build\libgit2.vcxproj]
  ignore.c
C:\Program Files\Microsoft SDKs\Windows\v7.1\include\winbase.h(2288): error C2373: 'InterlockedIncrement' : redefinition; different type modifiers [C:\Users\kevin\Documents\GitHub\git-utils\build\libgit2.vcxproj]
C:\Program Files\Microsoft SDKs\Windows\v7.1\include\winbase.h(2295): error C2373: 'InterlockedDecrement' : redefinition; different type modifiers [C:\Users\kevin\Documents\GitHub\git-utils\build\libgit2.vcxproj]
C:\Program Files\Microsoft SDKs\Windows\v7.1\include\winbase.h(2314): error C2373: 'InterlockedExchangeAdd' : redefinition; different type modifiers [C:\Users\kevin\Documents\GitHub\git-utils\build\libgit2.vcxproj]

zcbenz · 2013-10-28T05:06:08Z

This is a bug of libgit2, see libgit2/libgit2#1915.

zcbenz added 11 commits October 18, 2013 12:30

Use gyp instead of cmake to build libgit2.

d740e8d

It's too cumbersome to setup all the building environments on Windows with the default cmake, using gyp would reduce to building requirements to minimum.

Fix building on Windows.

3baeecf

Remove unneeded string copy.

ece014c

Update node-cpplint to v0.1.5.

8d7027f

Update jasmine-focused to v0.15.0.

b6b6596

Supress compiler warnings on Windows.

65648c8

VLA is not available in MSVC.

f4c706a

Fix specs that has wrong path delimiter on Windows.

239dbf5

Fix repo.relativize on Windows.

6cce9d0

Skip the symbol link test on Windows.

8d4a6d3

Fix git.open on Windows.

1f1c160

zcbenz added a commit that referenced this pull request Oct 20, 2013

Merge pull request #7 from atom/gyp

a0b5522

Port to Windows

zcbenz merged commit a0b5522 into master Oct 20, 2013

zcbenz deleted the gyp branch October 20, 2013 03:09

anaisbetts mentioned this pull request Oct 23, 2013

Build failure on Windows #8

Closed

mcolyer mentioned this pull request Oct 25, 2013

Windows Support atom/atom#1035

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port to Windows #7

Port to Windows #7

zcbenz commented Oct 18, 2013

mcolyer commented Oct 25, 2013

zcbenz commented Oct 28, 2013

kevinsawicki commented Oct 28, 2013

zcbenz commented Oct 28, 2013

Port to Windows #7

Port to Windows #7

Conversation

zcbenz commented Oct 18, 2013

mcolyer commented Oct 25, 2013

zcbenz commented Oct 28, 2013

kevinsawicki commented Oct 28, 2013

zcbenz commented Oct 28, 2013