Merge 755bacb into 71c1781

atom · Aug 24, 2018 · 30f94ca · 30f94ca
2 parents 71c1781 + 755bacb
commit 30f94ca
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/controllers/file-patch-controller.js b/lib/controllers/file-patch-controller.js
@@ -37,7 +37,7 @@ export default class FilePatchController extends React.Component {
 
   static buildURI(relPath, workdir, stagingStatus) {
     return 'atom-github://file-patch/' +
-      relPath +
+      encodeURIComponent(relPath) +
       `?workdir=${encodeURIComponent(workdir)}` +
       `&stagingStatus=${encodeURIComponent(stagingStatus)}`;
   }

diff --git a/test/controllers/file-patch-controller.test.js b/test/controllers/file-patch-controller.test.js
@@ -96,6 +96,18 @@ describe('FilePatchController', function() {
 
       getFilePatchForPath = sinon.stub(repository, 'getFilePatchForPath');
     });
+    describe('buildURI', function() {
+      it('correctly uri encodes all components', function() {
+        const filePathWithSpecialChars = '???.txt';
+        const stagingStatus = 'staged';
+        const URI = FilePatchController.buildURI(filePathWithSpecialChars, workdirPath, stagingStatus);
+        assert.isTrue(URI.includes(encodeURIComponent(filePathWithSpecialChars)));
+        assert.isTrue(URI.includes(encodeURIComponent(workdirPath)));
+        assert.isTrue(URI.includes(encodeURIComponent(stagingStatus)));
+      });
+
+    });
+
 
     describe('when the FilePatch is too large', function() {
       it('renders a confirmation widget', async function() {