Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Commit

Permalink
CI: Use 'windows-2019' image for Windows tests
Browse files Browse the repository at this point in the history
'windows-latest' is currently 'windows-2022'
with Visual Studio 2022.

Old versions of node-gyp don't know how to find Visual Studio 2022,
so the package build fails.

Switch back to 'windows-2019' with Visual Studio 2019,
which is supported by node-gyp 5.x, which apm still uses.
  • Loading branch information
DeeDeeG committed Apr 17, 2022
1 parent be2baf3 commit f867d24
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
name: tests
strategy:
matrix:
os: [ubuntu-18.04, macos-latest, windows-latest]
os: [ubuntu-18.04, macos-latest, windows-2019]
channel: [beta, nightly]
fail-fast: false
runs-on: ${{ matrix.os }}
Expand Down

0 comments on commit f867d24

Please sign in to comment.