Clicking "Commit" in GitHub integration doesn't do anything

[kpaulisse]

Description

Clicking "Commit" in GitHub integration doesn't do anything

Steps to Reproduce

1. Change a file
2. Save that file
3. Type a commit message
4. Click the "Commit" button

Expected behavior:

Commit the change, or display an error message about a failed hook.

Actual behavior:

Nothing at all.

Reproduces how often:

100%

I went through the recent commit history to master. It worked correctly in a3b0500 and does not work correctly in ba757d5. Hope that helps...

Versions

Atom    : 1.16.0
Electron: 1.3.13
Chrome  : 52.0.2743.82
Node    : 6.5.0

apm  1.16.1
npm  3.10.5
node 6.9.5 x64
python 2.7.10
git 2.10.1

Mac OS El Capitan

Additional Information

I've seen this on multiple repos, including those with pre-commit hooks and those without.

[smashwilson]

I can't repro on ca87e37 (OS X Sierra). Can you enable git diagnostics in the GitHub package settings, try again, and share the (expanded) command output from your dev console? You should be able to see the git process' stdout, stderr and exit code, which should help us track down (a) what's stopping the commit from happening and (b) why the error isn't being reported properly.

[kpaulisse]

This is what I see in ca87e37:

main.coffee:7 activate aligner-puppet
main.coffee:7 activate aligner-ruby
/Users/kpaulisse/github/atom-github/node_modules/react-dom/lib/ReactDOM.js:73 Download the React DevTools and use an HTTP server (instead of a file: URL) for a better development experience: https://fb.me/react-devtools
warning.js:36 Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.printWarning @ warning.js:36
init.coffee:9 activate linter-puppet
git-shell-out-strategy.js:192 git:git rev-parse --resolve-git-dir /Users/kpaulisse/github/test/.git in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 0
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 /Users/kpaulisse/github/test/.git

git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:39.651856 git.c:371               trace: built-in: git 'rev-parse' '--resolve-git-dir' '/Users/kpaulisse/github/test/.git'

git-shell-out-strategy.js:192 git:git config atomGithub.historySha in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 1
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 
git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:39.679410 git.c:371               trace: built-in: git 'config' 'atomGithub.historySha'

git-shell-out-strategy.js:192 git:git config --local --get-regexp ^remote..*.url$ in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 0
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 remote.origin.url https://github.com/kpaulisse/test.git

git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:39.716964 git.c:371               trace: built-in: git 'config' '--local' '--get-regexp' '^remote..*.url$'

git-shell-out-strategy.js:192 git:git status --untracked-files=all -z in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 0
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 
git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:39.709562 git.c:371               trace: built-in: git 'status' '--untracked-files=all' '-z'

git-shell-out-strategy.js:192 git:git for-each-ref --format=%(refname:short) refs/heads/* in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 0
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 kpaulisse-test
master

git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:39.702662 git.c:371               trace: built-in: git 'for-each-ref' '--format=%(refname:short)' 'refs/heads/*'

/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git symbolic-ref --short HEAD in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 0
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 kpaulisse-test

git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:39.695691 git.c:371               trace: built-in: git 'symbolic-ref' '--short' 'HEAD'

/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git rev-parse --symbolic-full-name kpaulisse-test@{push} in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 128
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 kpaulisse-test@{push}

git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:39.759865 git.c:371               trace: built-in: git 'rev-parse' '--symbolic-full-name' 'kpaulisse-test@{push}'
fatal: ambiguous argument 'kpaulisse-test@{push}': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git config branch.kpaulisse-test.remote in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 1
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 
git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:39.753237 git.c:371               trace: built-in: git 'config' 'branch.kpaulisse-test.remote'

/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git log --pretty=%H%x00%B%x00 --no-abbrev-commit -1 HEAD in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 0
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 a50afe70f8d54352a699d47606532e33aa98dab4�Foo
�

git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:39.743973 git.c:371               trace: built-in: git 'log' '--pretty=%H%x00%B%x00' '--no-abbrev-commit' '-1' 'HEAD'

/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git config atomGithub.currentRemote in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 1
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 
git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:39.735628 git.c:371               trace: built-in: git 'config' 'atomGithub.currentRemote'

/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git config branch.kpaulisse-test.atomPrUrl in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 1
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 
git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:39.806120 git.c:371               trace: built-in: git 'config' 'branch.kpaulisse-test.atomPrUrl'

/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git rev-parse --symbolic-full-name kpaulisse-test@{upstream} in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 128
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 
git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:39.799626 git.c:371               trace: built-in: git 'rev-parse' '--symbolic-full-name' 'kpaulisse-test@{upstream}'
fatal: no upstream configured for branch 'kpaulisse-test'

/Users/kpaulisse/.atom/packages/linter-ui-default/node_modules/react-dom/lib/ReactDOM.js:73 Download the React DevTools and use an HTTP server (instead of a file: URL) for a better development experience: https://fb.me/react-devtools
/Users/kpaulisse/.atom/packages/linter-ui-default/node_modules/fbjs/lib/warning.js:36 Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.printWarning @ /Users/kpaulisse/.atom/packages/linter-ui-default/node_modules/fbjs/lib/warning.js:36
/Applications/Atom.app/Contents/Resources/app.asar/src/config.js:680 'atom-beautify.yaml.padding' could not set the default. Attempted default: undefined; Schema: {"type":"integer","default":null,"minimum":0,"description":"The amount of padding to add next to each line. (Supported by align-yaml)","title":"Padding","beautifiers":["align-yaml"],"key":"padding","language":{"name":"YAML","namespace":"yaml"}}
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git status --untracked-files=all -z in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 0
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195  M README.md�
git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:44.419077 git.c:371               trace: built-in: git 'status' '--untracked-files=all' '-z'

/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git add README.md in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 0
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 
git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:45.429705 git.c:371               trace: built-in: git 'add' 'README.md'

/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git status --untracked-files=all -z in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 0
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 M  README.md�
git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:45.444067 git.c:371               trace: built-in: git 'status' '--untracked-files=all' '-z'

/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git status --untracked-files=all -z in /Users/kpaulisse/github/test
git-shell-out-strategy.js:193 exit status 0
git-shell-out-strategy.js:194 stdout
git-shell-out-strategy.js:195 M  README.md�
git-shell-out-strategy.js:196 stderr
git-shell-out-strategy.js:197 14:41:45.474841 git.c:371               trace: built-in: git 'status' '--untracked-files=all' '-z'

versus in a3b0500 which works:

activate aligner-puppet
main.coffee:7 activate aligner-ruby
/Users/kpaulisse/github/atom-github/node_modules/react-dom/lib/ReactDOM.js:73 Download the React DevTools and use an HTTP server (instead of a file: URL) for a better development experience: https://fb.me/react-devtools
warning.js:36 Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.printWarning @ warning.js:36
init.coffee:9 activate linter-puppet
git-shell-out-strategy.js:192 git:git rev-parse --resolve-git-dir /Users/kpaulisse/github/test/.git in /Users/kpaulisse/github/test
git-shell-out-strategy.js:192 git:git config atomGithub.historySha in /Users/kpaulisse/github/test
git-shell-out-strategy.js:192 git:git config --local --get-regexp ^remote..*.url$ in /Users/kpaulisse/github/test
git-shell-out-strategy.js:192 git:git status --untracked-files=all -z in /Users/kpaulisse/github/test
git-shell-out-strategy.js:192 git:git for-each-ref --format=%(refname:short) refs/heads/* in /Users/kpaulisse/github/test
git-shell-out-strategy.js:192 git:git symbolic-ref --short HEAD in /Users/kpaulisse/github/test
git-shell-out-strategy.js:192 git:git rev-parse --symbolic-full-name kpaulisse-test@{push} in /Users/kpaulisse/github/test
git-shell-out-strategy.js:192 git:git config branch.kpaulisse-test.remote in /Users/kpaulisse/github/test
git-shell-out-strategy.js:192 git:git log --pretty=%H%x00%B%x00 --no-abbrev-commit -1 HEAD in /Users/kpaulisse/github/test
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git config atomGithub.currentRemote in /Users/kpaulisse/github/test
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git rev-parse --symbolic-full-name kpaulisse-test@{upstream} in /Users/kpaulisse/github/test
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git config branch.kpaulisse-test.atomPrUrl in /Users/kpaulisse/github/test
/Users/kpaulisse/.atom/packages/linter-ui-default/node_modules/react-dom/lib/ReactDOM.js:73 Download the React DevTools and use an HTTP server (instead of a file: URL) for a better development experience: https://fb.me/react-devtools
/Users/kpaulisse/.atom/packages/linter-ui-default/node_modules/fbjs/lib/warning.js:36 Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.printWarning @ /Users/kpaulisse/.atom/packages/linter-ui-default/node_modules/fbjs/lib/warning.js:36
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git -c gpg.program=/Users/kpaulisse/github/atom-github/bin/gpg-no-tty.sh commit -m Foo in /Users/kpaulisse/github/test
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git status --untracked-files=all -z in /Users/kpaulisse/github/test
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git status --untracked-files=all -z in /Users/kpaulisse/github/test
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git rev-parse --symbolic-full-name kpaulisse-test@{push} in /Users/kpaulisse/github/test
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git log --pretty=%H%x00%B%x00 --no-abbrev-commit -1 HEAD in /Users/kpaulisse/github/test
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git rev-parse --symbolic-full-name kpaulisse-test@{upstream} in /Users/kpaulisse/github/test
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git log --pretty=%H%x00%B%x00 --no-abbrev-commit -1 HEAD in /Users/kpaulisse/github/test
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git status --untracked-files=all -z in /Users/kpaulisse/github/test
/Users/kpaulisse/github/atom-github/lib/git-shell-out-strategy.js:259 git:git for-each-ref --format=%(refname:short) refs/heads/* in /Users/kpaulisse/github/test

[kpaulisse]

Additional observation is that immediately after clicking "Commit" the focus returns to the text box where you type the commit message. This is true whether clicking the button with the mouse, or hitting the space bar when the button has been selected via tabbing.

[smashwilson]

Oh, I see what's happening - since you're on stable instead of beta, you're hitting a bug when the tab tracker is using the panel API instead of the dock API.

I'm on the case 🔍