Don't allow empty commits

[joshaber]

I just noticed that we're fine with creating an empty commit. We should probably not allow that.

[joshaber]

@simurai Any thoughts on what the error state looks like?

[joshaber]

Or just disable the button until there are staged changes? But maybe that's not obvious enough?

[simurai]

Or just disable the button until there are staged changes? But maybe that's not obvious enough?

Maybe also show a notification? Or flash/shake the list as a more subtle hint.

[simurai]

Also, should writing a commit message be required? Then we could also flash/shake the commit editor in case it's empty.

[joshaber]

Also, should writing a commit message be required?

Probably. I'd say if they want to make a commit without a message, they can take that shit to the command line.

[simurai]

Ok.. if you add a class to the list and commit editor, I'll add some sort of flashing/shaking. Maybe is-required? Kinda like when filling out a form. Or is-incomplete, needs-action

Ohh.. wait: is-💩