Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Don't allow empty commits #113

Merged
merged 13 commits into from Apr 1, 2016
Merged

Don't allow empty commits #113

merged 13 commits into from Apr 1, 2016

Conversation

joshaber
Copy link
Contributor

@joshaber joshaber commented Apr 1, 2016

Fixes #91

/cc @simurai FYI, so you can Do Your Thing to it whenever you have time.

@joshaber joshaber merged commit 1d608a0 into master Apr 1, 2016
@joshaber joshaber deleted the no-emptiness branch April 1, 2016 18:26
@simurai
Copy link
Contributor

simurai commented Apr 2, 2016

Added a shake to the editor. But when there are no staged files, the is-required class gets also added to the editor instead of the file list.

error

If you don't wanna spend more time on this, we can keep it as is (showing the messages only). I think it's fine for now.

@joshaber
Copy link
Contributor Author

joshaber commented Apr 2, 2016

So good.

But when there are no staged files, the is-required class gets also added to the editor instead of the file list.

Ah yeah, I'll make a new issue about that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants