Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Fix typo in selector #1681

Merged
merged 2 commits into from
Sep 10, 2018
Merged

Fix typo in selector #1681

merged 2 commits into from
Sep 10, 2018

Conversation

annthurium
Copy link
Contributor

Fixes #1675

Requirements

Description of the Change

When I migrated to use the Command component instead of the command registry, I made a typo in the registry target. That means that none of these events were bubbling up to the correct selector, which broke keyboard input on the co author dialog.

I spent a half day trying to write unit tests for these changes to prevent future regressions. However, it ended up being tricker than I anticipated, because:

  • Enzyme doesn't have great support for key events.
  • I don't really understand why this whole proxyKeyCode was necessary to make keyboard events work with react-select in the first place. I'm sure there's a good reason, I just don't know what it is. I reached out to @niik in case he remembers. Knowing this will help me write a better test.

Co-Authored-By: David Wilson <daviwil@users.noreply.github.com>
@coveralls
Copy link

coveralls commented Sep 6, 2018

Coverage Status

Coverage increased (+0.08%) to 80.215% when pulling f5c6649 on tt-18-sept-coauthor-bug into e482833 on master.

@annthurium annthurium merged commit 51dac31 into master Sep 10, 2018
@annthurium annthurium deleted the tt-18-sept-coauthor-bug branch September 10, 2018 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants