This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1675
Requirements
Description of the Change
When I migrated to use the
Command
component instead of the command registry, I made a typo in the registry target. That means that none of these events were bubbling up to the correct selector, which broke keyboard input on the co author dialog.I spent a half day trying to write unit tests for these changes to prevent future regressions. However, it ended up being tricker than I anticipated, because:
proxyKeyCode
was necessary to make keyboard events work with react-select in the first place. I'm sure there's a good reason, I just don't know what it is. I reached out to @niik in case he remembers. Knowing this will help me write a better test.