This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Go-to-line without enter and cancel go-to #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for this pr @darkowlzz. We decided to go with #53 that was ported from #32. I'm going to close this PR. If you feel like the cancel feature is something that would be very useful. Can you create a new PR(off latest of master) and I'll see if it's something we can take in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of Dont wait till user presses Enter button #26, inspired by #32.
Auto-navigation when go-to-line miniEditor model stops changing. Also, undo navigation on cancel and enter for confirmed navigation to a given line.