Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update status bar when image is reloaded #133

Merged
merged 6 commits into from Dec 28, 2018

Conversation

Projects
None yet
2 participants
@TimvdLippe
Copy link
Contributor

TimvdLippe commented Jul 6, 2017

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

When an image is reloaded from disc, it assigns a new value to src with the current date, listens again for the on-load after the fact, to then fire an update. The status bar thus listens to this update and calculates the sizes again.

Alternate Designs

I am not aware of a different method to achieve this

Benefits

The status bar is updated again

Possible Drawbacks

I could not write a test for this. First of all, when I would copy displays the size of the image as is in the spec, it would throw TypeError: Cannot read property 'textContent' of null. For some reason there is state left over after the beforeEach, but I could not track down why.

Applicable Issues

Fixes #105

TimvdLippe added some commits Jul 6, 2017

Remove MutationObserver
Not sure why this did not work before, but I later realized
the MutationObserver is not necessary at all

@50Wliu 50Wliu added the needs-review label Jul 13, 2017

50Wliu added some commits Dec 28, 2018

@50Wliu 50Wliu removed the needs-review label Dec 28, 2018

50Wliu added some commits Dec 28, 2018

@50Wliu 50Wliu merged commit de2aa6a into atom:master Dec 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@TimvdLippe TimvdLippe deleted the TimvdLippe:update-status-bar branch Dec 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.