New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global background colour variable #179

Merged
merged 1 commit into from Jul 31, 2018

Conversation

Projects
None yet
2 participants
@Aerijo
Contributor

Aerijo commented Jul 25, 2018

My last PR added a choice for default background colour. As a global variable 馃槖.

This PR changes the value to a property of the ImageEditorView. I would have made it just local, but it might be more useful this way.

I could have moved it up to the main body of the constructor, but I don't think it really matters.

@Aerijo

This comment has been minimized.

Show comment
Hide comment
@Aerijo

Aerijo Jul 25, 2018

Contributor

@lee-dohm Sorry for the ping, I think this should be merged quickly though. Who knows what a stray global can do (granted, it's only created if the user opens an image).

Contributor

Aerijo commented Jul 25, 2018

@lee-dohm Sorry for the ping, I think this should be merged quickly though. Who knows what a stray global can do (granted, it's only created if the user opens an image).

@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Jul 31, 2018

Member

Pretty sure this isn't a global variable because of Node's module loading and protections, so at least it is module local instead of global.

Member

lee-dohm commented Jul 31, 2018

Pretty sure this isn't a global variable because of Node's module loading and protections, so at least it is module local instead of global.

@lee-dohm lee-dohm merged commit 3055e3e into atom:master Jul 31, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lee-dohm

This comment has been minimized.

Show comment
Hide comment
@lee-dohm

lee-dohm Jul 31, 2018

Member

Thanks for the help 馃帀

Member

lee-dohm commented Jul 31, 2018

Thanks for the help 馃帀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment