This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Remove global background colour variable #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lee-dohm Sorry for the ping, I think this should be merged quickly though. Who knows what a stray global can do (granted, it's only created if the user opens an image). |
|
Pretty sure this isn't a global variable because of Node's module loading and protections, so at least it is module local instead of global. |
|
Thanks for the help 馃帀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last PR added a choice for default background colour. As a global variable 馃槖.
This PR changes the value to a property of the
ImageEditorView. I would have made it just local, but it might be more useful this way.I could have moved it up to the main body of the constructor, but I don't think it really matters.