This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Added C4309 to ignored warnings on Windows build #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadick254
force-pushed
the
compile-warning-handling
branch
from
a002ead
to
edcde9d
Compare
This was referenced Jul 6, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
#58
Description of the Change
Added 4309 warning to ignored warnings list in binding.gyp
Alternate Designs
Do not fail on warnings altogether by changing WarnAsError to false in binding.gyp
Possible Drawbacks
Warning could be an issue under some conditions.
Verification Process
Not applicable.
Release Notes
Fixes issue with building for Windows 32bit using Electron 10.