This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
grammar fix #11: method signatures with generic parameters #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
Notice how method names with Generic parameters aren't parsed as
entity.name.function.cs
. You can tell becauseRegister<TEvent>
has no style applied.Also, Generic parameters aren't recognized in method return-types.
### After
Method names with Generic parameters are recognized as
entity.name.function.cs
, and the Generic params themselves are recognized.Generic params in return-types are also recognized.
### Known issue - Can't seem to figure out how to get generic params to be recognized after the first param. Tried to copy what `#parameters` pattern does, but doesn't seem to work here. Any help would be appreciated, but this is still an improvement even without this sub-fix.