You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages
Description
The commit: b6081eb restricts identifiers that is causing syntax highlighting failures for css selectors that include a forward slash for namespacing.
At Facebook, we use namespacing in our CSS rule definitions to help modularize our stylesheets. Our asset management pipeline then mangles the selectors to valid CSS selectors when delivering to the browser. Nuclide uses language-css for styling css files resulting in the undesired highlighting.
Also, you may be unaware the CSS spec already features a formal namespace construct, which this grammar is already highlighting. It would be strange (and potentially confusing) to tokenise Facebook's internal/non-standard "namespaces" in conjunction with "true" CSS namespaces.
A CSS selector which contains an unescaped slash is invalid: the entire selector block will be dropped from the parsed stylesheet. This is the sort of error that should be visible to a user.
You can always use your stylesheet to override the error highlighting:
Prerequisites
Description
The commit: b6081eb restricts identifiers that is causing syntax highlighting failures for css selectors that include a forward slash for namespacing.
At Facebook, we use namespacing in our CSS rule definitions to help modularize our stylesheets. Our asset management pipeline then mangles the selectors to valid CSS selectors when delivering to the browser. Nuclide uses language-css for styling css files resulting in the undesired highlighting.
cc @jgebhardt
Steps to Reproduce
Use a slash in your css selector (e.g. (
.something/another
).Versions
This change occured from Atom 1.14 -> Atom 1.15.
The text was updated successfully, but these errors were encountered: