This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix valid identifier/identified error highlighting #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostafaeweda
requested review from
benogle,
winstliu,
nathansobo and
kevinsawicki
|
I do believe this was discussed in #104 and ended with @kevinastone 👍ing @Alhadis's suggestion. |
|
@50Wliu can you please release this to |
|
To clarify: I did not give my approval of this PR; rather, I wanted to know if you had seen the discussion in #104 that seemed to end with the conclusion that this PR was not needed. Sorry if there was any confusion. |
|
I'm sorry about that, let me revert it |
mostafaeweda
added a commit
to mostafaeweda/language-css
that referenced
this pull request
Apr 14, 2017
mostafaeweda
added a commit
that referenced
this pull request
Apr 14, 2017
Revert "Merge pull request #112 from mostafaeweda/fix-slash-error-highlight
|
I went with the proposed solution in #104 & it works great - so, that won't be a problem anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Before:
Numerous Nuclide users are complaining already with the invalid CSS highlighting
matching
.no-highlight/abc {yielding an invalid highlight marker.After:
It highlights correctly:
Alternate Designs
I have no idea!