Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add in @-ms-viewport and @-o-viewport to CSS grammar #182

Merged
merged 2 commits into from
Jul 19, 2021

Conversation

jpcastberg
Copy link
Contributor

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

Adds support for vendor prefixes -ms- and -o- to the viewport at-rule

Alternate Designs

No alternatives considered, I think I have fixed it appropriately within the architecture.

Benefits

Css grammar support will reflect viewport syntax used in older browsers.

Possible Drawbacks

...none?

Applicable Issues

fixes #176

@jpcastberg
Copy link
Contributor Author

looking for a maintainer to take a look... @sadick254 ?

Copy link
Contributor

@sadick254 sadick254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you for contributing.

@sadick254 sadick254 merged commit 8c9b224 into atom:master Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in @-ms-viewport and @-o-viewport to CSS grammar
2 participants