Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Variable block declaration syntax highlighting broken by call assignment #130

Closed
ramya-rao-a opened this issue Jul 9, 2017 · 4 comments · Fixed by #133
Closed

Variable block declaration syntax highlighting broken by call assignment #130

ramya-rao-a opened this issue Jul 9, 2017 · 4 comments · Fixed by #133
Labels

Comments

@ramya-rao-a
Copy link

From @willfaught on July 8, 2017 0:8

Can be seen with this syntax:

var (
	AAA = foo() // AAA is correctly light blue
	BBB string  // BBB is incorrectly white; it should be light blue like AAA
)

Note: GitHub syntax highlighting for the above doesn't show the problem.

See the screenshot:

screen shot 2017-07-07 at 5 04 33 pm

VS Code: Version 1.13.1 (1.13.1), 379d2efb5539b09112c793d3d9a413017d736f89
OS: macOS Sierra 10.12.5 (16F73)

Copied from original issue: microsoft/vscode-go#1071

@ramya-rao-a
Copy link
Author

@50Wliu Another var and () issue.

This must be a regression. I cannot repro in Atom 1.18.0. But I can repro when using atom --dev after running apm dev language-go

@ramya-rao-a
Copy link
Author

VS Code is using the version c1fe618

@50Wliu 50Wliu added the bug label Jul 9, 2017
@50Wliu
Copy link
Contributor

50Wliu commented Jul 16, 2017

This one might be a bit tricky.

50Wliu added a commit that referenced this issue Jul 16, 2017
@ramya-rao-a
Copy link
Author

@50Wliu May I just say that you are our grammar champion :)

I have lost the count of the number of times I have moved a grammar related bug to this repo and you have fixed it.

I wanted to thank you for all your work and I really appreciate everything you do 👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants