Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

syntax coloring is broken for some floating point constants #69

Closed
unreasonableman opened this issue Nov 30, 2016 · 2 comments
Closed

syntax coloring is broken for some floating point constants #69

unreasonableman opened this issue Nov 30, 2016 · 2 comments
Assignees
@50Wliu
Labels
bug triaged

Comments

@unreasonableman
Copy link

Hi,

java syntax coloring breaks for some floating point constants:

float foo = 0.1f; // okay
float bar = .1f; // not okay

The latter case leads to '1f' being highlighted in bright red.

Pic attached to illustrate the issue.

atom-syntax
@50Wliu
Copy link
Contributor

50Wliu commented Dec 1, 2016

Thanks for the issue @unreasonableman!

@50Wliu 50Wliu added the bug label Dec 1, 2016
@50Wliu 50Wliu self-assigned this Dec 1, 2016
50Wliu added a commit that referenced this issue Dec 1, 2016
@50Wliu
Overhaul numeric matching based on the offical specs
17edc9d 
http://docs.oracle.com/javase/specs/jls/se8/html/jls-3.html#jls-3.10.1
http://docs.oracle.com/javase/specs/jls/se8/html/jls-3.html#jls-3.10.2

Fixes #69
@50Wliu 50Wliu mentioned this issue Dec 1, 2016
Merged
3 tasks
@50Wliu
Copy link
Contributor

50Wliu commented Dec 1, 2016

Ok, I have a fix at #70. If you want to test it out you can check it out using Git and then apm link it. Make sure not to forget to unlink it though after an Atom version is released that contains the fix.

@50Wliu 50Wliu added the triaged label Jan 6, 2017
@50Wliu 50Wliu closed this as completed in #70 Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@50Wliu 50Wliu

Labels
bug triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unreasonableman @50Wliu