New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add varargs scope #130

Merged
merged 2 commits into from Mar 5, 2018

Conversation

Projects
None yet
2 participants
@sadikovi
Member

sadikovi commented Feb 20, 2018

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This PR adds new scope for variable length arguments list denoted as ..., for example,

void func(String ... args) {
  // code
}

Name of the scope is punctuation.definition.parameters.varargs and it is added to the parameters list of patterns.

Tested manually on different code snippets and added unittest.

Alternate Designs

None were considered, since the change is fairly straightforward. I did change scope name for this to
punctuation.definition.parameters.varargs.java.

Benefits

Adds new scope for varargs.

Possible Drawbacks

Should not be any, change is fairly minor and only affects parameters list for functions and methods.

Applicable Issues

Closes #129

@sadikovi

This comment has been minimized.

Member

sadikovi commented Feb 20, 2018

@50Wliu @chbk would you mind reviewing this PR? Thanks!

},
{
'match': '\\.\\.\\.'
'name': 'punctuation.definition.parameters.varargs'

This comment has been minimized.

@50Wliu

50Wliu Mar 5, 2018

Member

.java

Ivan Sadikov
@sadikovi

This comment has been minimized.

Member

sadikovi commented Mar 5, 2018

@50Wliu I updated the scope name. Can you have a look again? Thanks!

@50Wliu

50Wliu approved these changes Mar 5, 2018

@sadikovi sadikovi merged commit cfbfd32 into atom:master Mar 5, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sadikovi sadikovi deleted the sadikovi:vararg-scope branch Mar 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment