This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add support for "yield", "sealed", and "permits" Java keywords #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadikovi
added a commit
that referenced
this pull request
Oct 3, 2020
### Requirements * Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion. * All new code requires tests to ensure against regressions ### Description of the Change This PR adds `non-sealed` keyword as a follow-up to #234. I also had to update the class pattern to capture `-` that is in the keyword. ### Alternate Designs N/A. ### Benefits Adds support for `non-sealed` keyword. ### Possible Drawbacks N/A. ### Applicable Issues Fixes #236
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
This PR adds support for JDK 13+ keywords:
yieldsealedpermitsyieldkeyword is similar toreturn, so it is handled as "keyword.control.java".sealedandpermitsare only for classes and interfaces:sealedkeyword is a "storage.modifier.java" andpermitsis handled similar toextendsandimplementskeywords.Alternate Designs
No alternative designs were considered.
Benefits
Fixes highlighting of the aforementioned keywords.
Possible Drawbacks
Might potentially break class
extendsandimplementsscopes, but that would have to be a corner case not handled by unit tests.Applicable Issues
Fixes #230
Fixes #232