This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Highlight unescaped multiline strings as invalid #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,6 +31,21 @@ describe "Javascript grammar", -> | |||
| expect(tokens[2].value).toEqual delim | |||
| expect(tokens[2].scopes).toEqual ["source.js", scope, "punctuation.definition.string.end.js"] | |||
|
|
|||
| it "tokenizes invalid multiline strings", -> | |||
| lines = grammar.tokenizeLines("'line1\nline2\\\nline3'") | |||
There was a problem hiding this comment.
It would be nice if you can span this over multiple lines instead of using \n (see examples further down)
|
Thanks a lot for this @pchaigno, tried solving this by myself a few weeks ago but couldn't get it to work. |
You're welcome. That was a tough one. |
50Wliu
added a commit
that referenced
this pull request
Aug 26, 2015
Highlight unescaped multiline strings as invalid
|
⛵ |
|
🎉 |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements a change requested in #58.
Currently unescaped multiline strings are highlighted as if they were correct:
This change will highlight such strings as invalid.
Example of an invalid string with this change in Lightshow.
/cc @cydrobolt