Support for properties, function/method calls

[MaximSokolov]

Adds support for properties, function calls, method calls.

Fixes #37, fixes #241
Replaces: closes #217, closes #146
Refs #137

[50Wliu]

I've been pretty busy but I'll try to review this as soon as possible 😄.

[Stanzilla]

+1

[50Wliu]

I don't really see the benefit of using (?x) here since the regex is pretty simple. Same goes for below.

[50Wliu]

👍 Looks good for the most part!

[MaximSokolov]

Atom Dark

One Dark

Monokai

Also syntax themes should be updated probably:

.meta.method-call, .meta.function-call {
  & > .entity.name.function {
      color: @syntax-text-color;
  }
}

or
Edit: Isn't a good option since not all lanugages wrap function declaration with meta.function

// Highlight function name only in function declaration
.meta.function {
  .entity.name.function {
      color: @color;
  }
}

/cc @simurai

[50Wliu]

This will probably warrant spec changes in Atom core - it did last time at least. I'll just wait for simurai and then merge and create a PR.

[simurai]

Tested with https://github.com/atom/language-examples/blob/master/languages/javascript.js

.meta.method-call, .meta.function-call {
  .entity.name.function {
      color: @syntax-text-color;
  }
}

// Highlight function name only in function declaration
.meta.function {
  .entity.name.function {
      color: @hue-6-2;
  }
}

Doesn't it make more sense to keep the function name and function call the same color? Basically without changing the themes.

Also, should it be scoped to JavaScript only? If not, I think option 2 would also affect other languages, like C.

[MaximSokolov]

Screenshot 2 should be the same as screenshot 1:

By option 2 I meant .entity.name.function {...} -> .meta.function .entity.name.function {...}
I thought all languages wrap a function name in declaration with meta.function (not all of them do)

Doesn't it make more sense to keep the function name and function call the same color? Basically without changing the themes.

Well, this can be merged, if you think it looks ok

[50Wliu]

👏 🎉