This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Remove source.shell#string to fix #44 $(error ...) constructs #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Removes
source.shell#variablefrom the inner content of$(error ..)etc. constricts. This fixes #44. As far as I can tell there are no regressions in my own files.Benefits
Basically,
$(error ..)etc. syntax was being messed up by the presence of quotes or apostrophes, as seen in the screenshot in the issue. We don't need to have any special consideration for quotes or apostrophes because they are included verbatim in the output, no need to escape them.Possible Drawbacks
There could be regressions, or cases I haven't considered, but everything seems to work fine.
Applicable Issues
This fixes #44.