This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
[ISSUE-3] forcing hard tabs for make files #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| atom.workspaceView.eachEditorView (editorView) -> | ||
| editor = editorView.getEditor() | ||
| grammarScope = editor.getGrammar()['scopeName'] | ||
| if grammarScope is 'text.plain.null-grammar' |
There was a problem hiding this comment.
This is here because when you load a makefile directly without atom already running (ie: atom Makefile), the Makefile language isn't loaded before this code is run so the scope is set to a null-grammar.
In this case, I fall back to parsing the file type directly so that it will still work on that first load.
|
This is related to atom/atom#1723. The goal is to have a general solution for all grammars. |
|
+1 |
parabuzzle
changed the title
parabuzzle
changed the title
|
This was fixed in core via atom/atom@7abfd45 and will be handled in the future by supporting a scoped setting so this can be opt-in for any grammar. So I'm going to close out this PR, sorry for not providing timely updates and feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #3