This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Improve "function __construct" snippet #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create new line after brackets (as PSR-2 recomments) - Add visibility to the method (`public` as default) - Add type to the first argument - Define a property name as the same of the first argument
|
LGTM! 👍 Behaves a lot better than the previous one. |
|
It's been a long time since I've opened this pull request, is it going to be merged? |
kevinsawicki
added a commit
that referenced
this pull request
Nov 9, 2015
Improve "function __construct" snippet
|
Great, thanks for this, apologies for the delay |
|
No problem :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
publicas default)The snippet should create something like: