This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Beautify some long patterns #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ( | ||
| ([A-Z]\\w*(::))? | ||
| ([A-Z]\\w*(::))? | ||
| ([A-Z]\\w*(::))* |
There was a problem hiding this comment.
...what. Are the three separate matches really necessary?
There was a problem hiding this comment.
😂 Me too… I wanted to remove them. But on second thought, this PR is already big enough, so I decided to stick to what I planned to do here—just beautify things, to keep it simple, coz not just this one, other rules could also use some refinements. Maybe another PR?
|
Anything else? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.