Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Change Forwardable Snippit to Forw. #9

Merged
merged 1 commit into from
Mar 1, 2014

Conversation

patricksrobertson
Copy link
Contributor

I was unable to get the Forwardable snippit to work as implemented.

I was unable to get the Forwardable snippit to work as implemented.
@JAStanton
Copy link

This is a temporary fix. I hope this isn't the permanent solution.
Same bug here:
atom/language-php#7 (comment)

kevinsawicki added a commit that referenced this pull request Mar 1, 2014
@kevinsawicki kevinsawicki merged commit e22e04a into atom:master Mar 1, 2014
@kevinsawicki
Copy link
Contributor

Thanks for fixing this.

@JAStanton
Copy link

@kevinsawicki it's still broken underneath though. Did you see my comment?

@kevinsawicki
Copy link
Contributor

@JAStanton I did, thanks for pointing it out.

I merged this PR since it seems like having a shorter snippet prefix was better overall regardless of whether having - in it actually works, which is something that definitely does need to be fixed.

@JAStanton
Copy link

@kevinsawicki ah yeah actually you're right it does look like the snippet should be shorter. I just wish Atom was already opensourced so I could file a bug for this ;)

@kevinsawicki
Copy link
Contributor

Snippets support is 100% open source, it is completely isolated to this package: https://github.com/atom/snippets

@JAStanton
Copy link

For reference this is the underlying issue: atom/snippets#12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants