Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Use .css instead of .scss in property lists #180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

50Wliu
Copy link
Contributor

@50Wliu 50Wliu commented Sep 29, 2016

This change brings language-sass in line with language-css and language-less. The main goal of this PR is to allow for deduplication in autocomplete-css.

@50Wliu
Copy link
Contributor Author

50Wliu commented Oct 9, 2016

/cc @esdoppio for language review, @simurai for styling. There shouldn't be anything explicitly targeting the .scss variant, right?

@hediyi
Copy link
Contributor

hediyi commented Oct 9, 2016

Theoretically, I think "meta.property-list.scss" should remain as it is, because unlike property-name or property-value, what can go into a "property list" (still don't like the name) of SCSS is very different from that of CSS. But other than that, I don't see why we can't change it.

Copy link

@simurai simurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with this.

I don't think themes want style properties differently in SCSS vs CSS. And I think they still can with a more specific selector, like .source.scss xxx.css.

@50Wliu
Copy link
Contributor Author

50Wliu commented Oct 11, 2016

Alternatively, we could use meta.property-list.css.scss. Any thoughts about that?

@simurai
Copy link

simurai commented Oct 11, 2016

Yeah, I guess having both (.css.scss) would lower the chance of breaking anything.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants