This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix FindCredentials size on windows #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @cryppadotta, was the issue that you're fixing causing a bug in Atom or are you seeing an issue somewhere else? /cc @daviwil |
`FindCredentials` was missing passing the `CredentialBlobSize` which resulted in an extra character at the end of the password for some values. Fixes: atom#96
daviwil
force-pushed
the
patch-1
branch
2 times, most recently
from
31d25a5
to
37363e8
Compare
|
Added a test to exercise the change and found another issue with findCredentials not using unicode correctly on Windows. Thanks a lot for the PR @cryppadotta! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindCredentialswas missing passing theCredentialBlobSizewhich resulted in an extra character at the end of the password for some values. Fixes: #96