This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Crash when parsing invalid/malformed UTF16 #56
Labels
Comments
maxbrunsfeld
pushed a commit
that referenced
this issue
Sep 20, 2016
Fixes #56: Do not ignore unmatched high surrogates, check index is within bounds
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
From microsoft/vscode#10945
The UTF16<->UTF8 offset map computation in
OnigStringskips unmatched high surrogates, while v8's UTF16->UTF8 converter interprets them as "literal" code points.This can lead to a situation where
utf8OffsetToUtf16is not completely initialized (as the unmatched high surrogates are skipped).Moreover, the
ConvertUtf8OffsetToUtf16andConvertUtf16OffsetToUtf8are lacking index bounds checks.I have a PR ready to fix these issues, sorry about introducing them in the first place.
The text was updated successfully, but these errors were encountered: