This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix builds with newer node. #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
We don't want to break compatibility with Node v8 just yet
|
Thanks for the PR! I've added a couple of commits to it to try to get a green build. Basically, I've added back support to Node v8 since it's too early to drop support to it for Atom (Atom just moved to Node v10 last week so in case we need to revert back Node v8 we want this module to keep working 😄). Once/if the CI builds are green I'll merge this one and publish a new version of the package. |
Appveyor still does not support Node v12: appveyor/ci#2921
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of my quest to add spell checking to riot (element-hq/element-web#2661), first this package needs to compile.
Signed-off-by: Hal Gentz zegentzy@protonmail.com