Disabled core packages couldn't be enabled from UI

[xeron]

Disabled core packages are missing from installed packages list.

Only way to enable them is to edit config.cson and remove lines from "disabledPackages" array.

This issue affects only core packages. I can't reproduce it with 3rd party ones.

[kevinsawicki]

Do you mean the package isn't showing in the menu on the left hand side of the settings view?

I tried disabling the Archive View package to reproduce, but I still see it in the list there.

Can you share a screenshot of what you are seeing? Thanks.

[xeron]

Yes this is what I mean.

Steps to reproduce:

1. Disable any core package (I'm testing with "Git Diff")
2. Restart Atom
3. Try to enable this package again using UI

[lee-dohm]

Verified with Atom v0.141.0-7ed6e68 on OS X 10.10 using the autosave package.

[lee-dohm]

It looks like the issue is at:

https://github.com/atom/settings-view/blob/master/lib/settings-view.coffee#L109

Core installed packages don't have a package.json so metadataPath is null.

[kevinsawicki]

@lee-dohm Thanks, that is definitely it.

[kevinsawicki]

This will be fixed in 0.141, thanks for reporting it.

[xeron]

Awesome, thank you!