Deactivate correctly, take 2 #1036

50Wliu · 2018-01-03T23:34:49Z

Requirements

Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
All new code requires tests to ensure against regressions

Description of the Change

Investigating pretty persistent failures of #976 on Travis.

See #1027 for the previous PR.

…disposables" This reverts commit 594c12f, reversing changes made to 25127a9.

50Wliu added 11 commits January 3, 2018 18:32

Try to debug pane opening failures

ab6654b

Revert "Merge pull request #1035 from atom/revert-1027-wl-deactivate-…

e6ba7ec

…disposables" This reverts commit 594c12f, reversing changes made to 25127a9.

What if we get rid of the waits?

c7f2279

Slowly rollback changes

423f329

Don't test anything that might touch PackageManager

d040639

And if we only try Editor?

5c6a4f6

Check packageManager's destroy calls

b0bc7c6

We need the prototype

306a600

Try using Trusty on Travis for faster feedback

ec1aadf

Travis please

3dcd922

Of course it's a macOS-only issue.

a46594b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deactivate correctly, take 2 #1036

Deactivate correctly, take 2 #1036

50Wliu commented Jan 3, 2018 •

edited

Loading

Deactivate correctly, take 2 #1036

Are you sure you want to change the base?

Deactivate correctly, take 2 #1036

Conversation

50Wliu commented Jan 3, 2018 • edited Loading

Requirements

Description of the Change

50Wliu commented Jan 3, 2018 •

edited

Loading