Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comma value in array #1103

Merged
merged 4 commits into from Feb 27, 2019

Conversation

Projects
None yet
3 participants
@UziTech
Copy link
Contributor

UziTech commented Jan 24, 2019

Description of the Change

array config type will allow an escaped comma in the value.

image

the config value will be ["1", ",", "2"]

Alternate Designs

Benefits

Comma can be used in array values.

Possible Drawbacks

none

Applicable Issues

fixes #1102
closes #1101

233cy and others added some commits Jan 23, 2019

增加array类型可以使用普通的逗号
增加array类型可以使用普通的逗号
@rafeca

rafeca approved these changes Feb 27, 2019

Copy link
Contributor

rafeca left a comment

Thanks for the contribution! LGTM

values.push(val)
}
return values
}, [])

This comment has been minimized.

@rafeca

rafeca Feb 27, 2019

Contributor

This logic is a bit convoluted, but I cannot think of a better way to do this without lookbehind regex support (I've just tried using lookbehind regexps on Atom and it seems like its Chromium version does not support them yet).

Maybe once Atom uses Electron 3 this can be refactored 😃

@rafeca rafeca merged commit 8e8c03e into atom:master Feb 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rafeca rafeca self-assigned this Feb 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.