This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Comma value in array #1103
Merged
Comma value in array #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 24, 2019
Closed
rafeca
approved these changes
Feb 27, 2019
| values.push(val) | ||
| } | ||
| return values | ||
| }, []) |
There was a problem hiding this comment.
This logic is a bit convoluted, but I cannot think of a better way to do this without lookbehind regex support (I've just tried using lookbehind regexps on Atom and it seems like its Chromium version does not support them yet).
Maybe once Atom uses Electron 3 this can be refactored 😃
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
arrayconfig type will allow an escaped comma in the value.the config value will be
["1", ",", "2"]Alternate Designs
Benefits
Comma can be used in array values.
Possible Drawbacks
none
Applicable Issues
fixes #1102
closes #1101