Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Support settings-view in docks #1115

Merged
merged 2 commits into from
Feb 22, 2019
Merged

Support settings-view in docks #1115

merged 2 commits into from
Feb 22, 2019

Conversation

simurai
Copy link
Contributor

@simurai simurai commented Feb 21, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This improves the layout of the settings-view when moved to the left/right dock.

settings

Alternate Designs

There are a few options for the navigation.

Benefits

When moving the settings-view to a dock, it allows you to keep the editor in sight. Great when making changes to the settings and then see the result in the editor.

settings

Possible Drawbacks

  • It is a bit experimental with just some CSS overrides.
  • The Keybindings need to be scrolled horizontally and fit better in the center.
  • Adds extra maintenance cost.

Applicable Issues

N/A

@simurai
Copy link
Contributor Author

simurai commented Feb 22, 2019

Here some navigation options

A: Open on hover

nav1

B: Icons only on the side

nav2

C: Text only in a grid

nav3

Ok, I think the winner is option C.

  • Always visible text.
  • No distracting hover effects
  • Only takes up two rows

I'll push this version.

@simurai simurai merged commit cc161ca into master Feb 22, 2019
@simurai simurai deleted the sm-settings-in-dock branch February 22, 2019 06:14
This was referenced Feb 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant