Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support settings-view in docks #1115

Merged
merged 2 commits into from Feb 22, 2019

Conversation

Projects
None yet
1 participant
@simurai
Copy link
Member

simurai commented Feb 21, 2019

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

This improves the layout of the settings-view when moved to the left/right dock.

settings

Alternate Designs

There are a few options for the navigation.

Benefits

When moving the settings-view to a dock, it allows you to keep the editor in sight. Great when making changes to the settings and then see the result in the editor.

settings

Possible Drawbacks

  • It is a bit experimental with just some CSS overrides.
  • The Keybindings need to be scrolled horizontally and fit better in the center.
  • Adds extra maintenance cost.

Applicable Issues

N/A

@simurai

This comment has been minimized.

Copy link
Member Author

simurai commented Feb 22, 2019

Here some navigation options

A: Open on hover

nav1

B: Icons only on the side

nav2

C: Text only in a grid

nav3

Ok, I think the winner is option C.

  • Always visible text.
  • No distracting hover effects
  • Only takes up two rows

I'll push this version.

@simurai simurai merged commit cc161ca into master Feb 22, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@simurai simurai deleted the sm-settings-in-dock branch Feb 22, 2019

This was referenced Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.