This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Show settings after install #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaching the results gives wrong results after a package has been installed as it is not aware of it when the package manager is initiated.
|
There is a bug in this implementation. When I'm on a package's settings page, the settings button is displayed:
|
|
@lee-dohm I've added a spec to verify this and fixed it. The settings button in now shown after install and not shown on the settings page of a package. |
|
Thanks very much @bastilian! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #650 by not removing the settings button and show after a package has been installed that has settings.
For this I had to remove
_.memoizeforPackageManager#packageHasSettingsas it returned a wrong result, this may effect rendering of longer package lists, but so far I have not noticed any negative effect.