Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

🐧 Fixed documentation for linux #184

Merged
merged 5 commits into from Nov 7, 2015
Merged

🐧 Fixed documentation for linux #184

merged 5 commits into from Nov 7, 2015

Conversation

riggtravis
Copy link
Contributor

Before the instructions for Linux were the same as for windows, which did not accurately describe the situation in Linux. I created issue #183 to describe this problem earlier. I searched through the project for other incorrect references of how to open the snippets file, but I couldn't find any. I would be willing to fix other instances of this problem if they exist.

Before the instructions for Linux were the same as for windows, which did not accurately describe the situation in Linux.
@@ -2,7 +2,7 @@

Expand snippets matching the current prefix with `tab` in Atom.

To add your own snippets, select the _Atom > Open Your Snippets_ menu option if you're using OSX or the _File > Open Your Snippets_ menu option if you're using Windows or Linux.
To add your own snippets, select the _Atom > Open Your Snippets_ menu option if you're using OSX, or the _File > Open Your Snippets_ menu option if you're using Windows, use the _Edit > Open Your Snippets_ menu option if you are using a Linux based operating system.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you didn't just specify "Linux" here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't figure out a phrasing that sounded right. I'll try to rephrase it.

@@ -2,7 +2,7 @@

Expand snippets matching the current prefix with `tab` in Atom.

To add your own snippets, select the _Atom > Open Your Snippets_ menu option if you're using OSX or the _File > Open Your Snippets_ menu option if you're using Windows or Linux.
To add your own snippets, select the _Atom > Open Your Snippets_ menu option if you're using OSX, or the _File > Open Your Snippets_ menu option if you're using Windows, use _Edit > Open Your Snippets_ if you are using Linux.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so after thinking about this, I think the best flow would go something like this:

To add your own snippets [...] using OS X, the [...] using Windows, or the Edit > Open Your Snippets menu option if you are using Linux.

Does that sound good to you?

(Also, note the new space in OS X - we're starting to standardize the usage of OS X over Mac and OSX, /cc @thomasjo)

@riggtravis
Copy link
Contributor Author

That sounds great! I'll make those modifications.

Changes suggested by @50Wliu
@@ -2,7 +2,7 @@

Expand snippets matching the current prefix with `tab` in Atom.

To add your own snippets, select the _Atom > Open Your Snippets_ menu option if you're using OSX or the _File > Open Your Snippets_ menu option if you're using Windows or Linux.
To add your own snippets, select the _Atom > Open Your Snippets_ menu option if you're using OS X, or the _File > Open Your Snippets_ menu option if you're using Windows,using Windows, or the _Edit > Open Your Snippets_ menu option if you are using Linux.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit: you put using Windows twice here 😉

@riggtravis
Copy link
Contributor Author

Well that's embarrassing I'll fix that when I get to my computer.

Because it just didn't need to be there.
50Wliu added a commit that referenced this pull request Nov 7, 2015
🐧 Fixed documentation for linux
@50Wliu 50Wliu merged commit cc29af8 into atom:master Nov 7, 2015
@50Wliu
Copy link
Contributor

50Wliu commented Nov 7, 2015

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants