This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Don't trigger expansion when prefix is part of a larger word #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @kevinsawicki; can you 👓 at this one too? |
|
Yeah, this sounds good to me, no common cases just to mind that this would "break" and I imagine this makes things more consistent with other editors people may be using snippets in. |
|
Ok, I think I'm going to say that this Fixes #59. |
maxbrunsfeld
pushed a commit
that referenced
this pull request
Jan 15, 2015
…prefixes Don't trigger expansion when prefix is part of a larger word
|
Oops after doing some testing, there are some cases where snippets still expand even as part of a larger word. I'm fixing it up. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if a snippet prefix precedes the cursor, snippet expansion is triggered by the
tabkey. This PR prevents triggering snippet expansion if the snippet prefix preceding the cursor is part of a larger word, as defined by theeditor.nonWordCharactersconfig setting.I'm not sure if this is the right thing to do, but I think it addresses issues raised by @dsandstrom in #59.