This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Tweak tests so that they work when Pane.close becomes async #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
This was referenced Jun 14, 2017
Closed
Changes required due to TextBuffer.save becoming async in Atom 1.19
greyatom-edu-tech/greyatom-ide#8
Open
Closed
Closed
Closed
Changes required due to TextBuffer.save becoming async in Atom 1.19
lkwdwrd/docblock-format-helper#5
Open
Closed
Open
This was referenced Jun 14, 2017
Open
Closed
Closed
Changes required due to TextBuffer.save becoming async in Atom 1.19
anaisbetts/saveallthetime-atom#9
Open
Open
Closed
Open
Closed
Open
Closed
Closed
Changes required due to TextBuffer.save becoming async in Atom 1.19
andrewrynhard/atom-latex-plus#85
Open
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TextBuffer.savemethod is going to become async in atom/atom#14435; instead of doing a synchronous write, it will initiate an asynchronous write and return a promise when the write completes. As a result, a few methods that depend on saving the buffer (likePane.close, which is private) are now async as well. This shouldn't affect the user-facing functionality of many packages; but several packages may have test failures.This PR updates the two tests in
tabsthat broke due to this change, so that they work regardless of whether save is synchronous or asynchronous.