Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Lines where coworker's profile picture shown not clickable #362

Closed
1 task done
mbergen opened this issue Apr 12, 2018 · 3 comments
Closed
1 task done

Lines where coworker's profile picture shown not clickable #362

mbergen opened this issue Apr 12, 2018 · 3 comments
Labels

Comments

@mbergen
Copy link

mbergen commented Apr 12, 2018

Prerequisites

  • Put an X between the brackets on this line if you have done all of the following:

Description

When working with one guest, the lines in whose on the right side the profile picture of the guest is shown are not clickable, so you can't place the cursor with your mouse/touchpad.
Appears also on the guest's side.

Steps to Reproduce

  1. Open a portal
  2. let at least one guest join
  3. try to place the cursor by mouse in the lines where on the side the picture of the coworker is shown

Expected behavior:

Cursor can be placed by mouse, like in every other line

Actual behavior:

Cursor is not placed

Reproduces how often:

100% since last update, but only have one other client to test with

Versions

atom --version
Atom : 1.25.1
Electron: 1.7.11
Chrome : 58.0.3029.110
Node : 7.9.0

apm --version
apm 1.19.0
npm 3.10.10
node 6.9.5 x64

OS: Windows 10 Pro 1709

@jasonrudolph
Copy link
Contributor

@mbergen: Thanks for reporting this issue. Nice catch! 🙇

Here's a quick demo for our future reference: Notice that clicking on lines 38, 39, and 40 causes the cursor to appear on those lines. Notice that clicking on lines 41 and 42 does not cause the cursor to appear on those lines.

demo

@mbergen
Copy link
Author

mbergen commented Apr 12, 2018

Thanks for the wonderful demo.
Just a small annotation to your comment @jasonrudolph :
line 40 is already where clicking does not cause the cursor to appear, whereas clicking on line 42 should work. (at least it does for me)

@simurai
Copy link
Contributor

simurai commented Apr 13, 2018

@mbergen Great catch. 👌

Looks like the wrapper for the avatars blocks clicks.

image

We should be able to only make avatars clickable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants