Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Rename repo to text-buffer? #1

Closed
kevinsawicki opened this issue Dec 31, 2013 · 3 comments
Closed

Rename repo to text-buffer? #1

kevinsawicki opened this issue Dec 31, 2013 · 3 comments

Comments

@kevinsawicki
Copy link
Contributor

Having the -core suffix makes me think this repo isn't usable without standalone but it is right?

If someone uses this as a module they will have a fully functional text-buffer and won't have to implement any methods themselves?

@nathansobo
Copy link
Contributor

There is a bunch of functionality related to the buffer being backed by files that's still in Atom. I'd be in favor of moving that over as well, but until we do I think it makes sense to distinguish this as "core". Otherwise what do we call the class that remains inside Atom?

@kevinsawicki
Copy link
Contributor Author

We can pull in the classes from this repo into atom by any class name we want.

We do this for first-mate, it didn't make sense to have a TextMate prefix to all class names in that library since it is only about TextMate helpers, but in atom we pull in the requires as TextMateScopeSelector to distinguish it as TextMate support.

@nathansobo
Copy link
Contributor

I was a bit worried about the official name in the heap profiler. Maybe it's not worth the concern.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants