Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Wrap fs.realpathSync in a try catch #1377

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Wrap fs.realpathSync in a try catch #1377

merged 1 commit into from
Apr 8, 2021

Conversation

sadick254
Copy link
Contributor

@sadick254 sadick254 commented Apr 8, 2021 •
edited
Loading

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions

Description of the Change

  • Wrap fs.realpathSync in a try-catch expression.

Alternate Designs

Benefits

  • Warn the user of the error detected when moving files.

Possible Drawbacks

N/A

Applicable Issues

atom/atom#22155

@sadick254 sadick254 force-pushed the catch-realpathSync-usage-on-invalid-path branch 3 times, most recently from 3c7cab8 to c7b5c4b Compare April 8, 2021 20:04
@sadick254
Wrap fs.realpathSync call in a try-catch
618e6cc 
Show user the error causing the move failure
@sadick254 sadick254 force-pushed the catch-realpathSync-usage-on-invalid-path branch from c7b5c4b to 618e6cc Compare April 8, 2021 20:11
@sadick254 sadick254 merged commit 345b375 into master Apr 8, 2021
@sadick254 sadick254 deleted the catch-realpathSync-usage-on-invalid-path branch April 8, 2021 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@sadick254