Add 'Show in Finder' context menu #47
Conversation
|
You're right. My intention was just to show 'Open in Finder' to folder objects, but I'm not sure how to update the context menu items during the runtime, but let's build something functional. I'll change it to 'Show in Finder', and update the command. bjtitus, I would like to know how to change the context menu text during runtime. Couldn't find how.
I'll fix this asap. |
|
Fixed. I'll update to Windows when I figure out how to update the context menu item text. |
|
All done, @bjtitus. |
| @@ -13,6 +13,9 @@ | |||
| "fs-plus": "2.x", | |||
| "temp": "~0.6.0", | |||
| "theorist": "1.x", | |||
| "underscore-plus": "1.x" | |||
| "underscore-plus": "1.x", | |||
| "grunt": "~0.4.2", | |||
There was a problem hiding this comment.
What was this grunt dependency needed for?
There was a problem hiding this comment.
Weird, I don't recall adding this line.
Edit: Found. mac-open had grunt as a peerDependency. Just sent them a PR to fix this.
|
I think for now just supporting Support for Windows Explorer can be added when Windows support is added. |
|
Okie dokie. I'll fix it asap. |
|
Fixed. |
| buttons: | ||
| 'OK': null | ||
|
|
||
|
|
| showInFinder(entry.getPath(), { R: true }) | ||
| catch error | ||
| atom.confirm | ||
| message: "Error showing #{entryType}" |
There was a problem hiding this comment.
How about: "Opening #{entryType} in Finder failed" ?
Add 'Show in Finder' context menu
|
Thanks for this, merged into master 🚢 |
|
I switched this to not use |
This adds a new 'Open in Finder' context menu item. Also fixes #44.