This repository has been archived by the owner on Apr 6, 2018. It is now read-only.
Make paragraph forward match Vim's behavior re: whitespace. #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🐛 Consecutive empty lines should not be treated as different paragraphs and whitespace only lines are not paragraph boundaries. http://vimdoc.sourceforge.net/htmldoc/motion.html#paragraph
|
I updated the regular expression to handle \r\n line endings. I temporarily modified the test on my machine to validate it, but I am not sure how the project wants to handle these tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Consecutive empty lines should not be treated as different paragraphs and
whitespace only lines are not paragraph boundaries.
http://vimdoc.sourceforge.net/htmldoc/motion.html#paragraph
I went in to fix the failing test on forward paragraph behavior and noticed that vim-mode also didn't match Vim for whitespace only line behavior. If this PR makes sense I can also take a look at backwards paragraph motion.