This repository has been archived by the owner on Apr 6, 2018. It is now read-only.
Fix for #689 and improve blank line handling for the ip/ap text-objects #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any feedback on this? |
|
I think it looks great. Definitely works better now. I notice that hitting undo after 'dap' or 'dip' leaves the cursor at the end of the deleted region. Vim leaves the cursor at the beginning of the deleted region. Might be worth opening a new issue for this though, not sure how deep this problem runs. Ideally you'd combine some of these commits so the changes are more obvious. |
|
Seems to need rebasing please. |
… ip/ap text-objects
|
Refactored and rebased. |
|
please remove |
|
Sneaky .swp removed :) |
| @@ -205,15 +205,36 @@ describe "TextObjects", -> | |||
| expect(editorElement.classList.contains('normal-mode')).toBe(true) | |||
|
|
|||
| it "selects inside the current paragraph in visual mode", -> | |||
|
|
|||
There was a problem hiding this comment.
this seems to be an unnecessary empty line; with or without it I'm still recommending an immediate merge for this PR 8-)
|
Great work @MarkusSN; thanks for fixing this! |
maxbrunsfeld
pushed a commit
that referenced
this pull request
Aug 12, 2015
Fix for #689 and improve blank line handling for the ip/ap text-objects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #689. Also makes the handling of blank lines, and lines that only contain whitespace more like in vim, e.g. you can now select the lines between two paragraphs by doing 'vip' .