This repository has been archived by the owner on Apr 6, 2018. It is now read-only.
Fix a scroll when contents are wrapped #970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # TODO: Atom v1.1.0 was released. | ||
| # But setFirstVisibleScreenRow() use getLineCount() not | ||
| # getScreenLineCount(). Once after it use getScreenLineCount(), | ||
| # [1. by setFirstVisibleScreenRow] can be changed to [2. by scrollTop] |
There was a problem hiding this comment.
But setFirstVisibleScreenRow() use getLineCount() not getScreenLineCount()
Thanks so much for catching this! I think that we should just fix that method. There are some issues with using the TextEditorElement::getScrollTop, because it doesn't always update until the next animation frame.
There was a problem hiding this comment.
@b6pzeusbc54tvhw5jgpyw8pwz2x6gs Are you interested in submitting a PR to atom/atom fixing this? I can publish a hotfix release of Atom so that we don't need to wait for 1.7.0 to come out.
There was a problem hiding this comment.
@maxbrunsfeld , ok I will PR to atom/atom.
|
Ok, I believed the atom/atom PR referenced above. Thanks @b6pzeusbc54tvhw5jgpyw8pwz2x6gs! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the document that has many wrapped contents, scroll handling commands (ctrl-d, ctrl-f and ctrl-e) can NOT move screen to end of document.
This PR refers to #968.
To explain the problem more details, I uploaded a video file.
video reproduce the problem
I hope it is helpful to check and review my PR.
Thank you.