Skip to content
This repository has been archived by the owner on Aug 12, 2019. It is now read-only.

Advertise Teletype #66

Merged
merged 2 commits into from Nov 21, 2017
Merged

Advertise Teletype #66

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54f1055
Add Teletype
Nov 20, 2017
2f0caf0
Rephrase Teletype title as a call-to-action
Nov 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
25 changes: 25 additions & 0 deletions lib/guide-view.js
View file
Open in desktop
Expand Up @@ -9,6 +9,7 @@ export default class GuideView {
this.didClickProjectButton = this.didClickProjectButton.bind(this)
this.didClickGitButton = this.didClickGitButton.bind(this)
this.didClickGitHubButton = this.didClickGitHubButton.bind(this)
this.didClickTeletypeButton = this.didClickTeletypeButton.bind(this)
this.didClickPackagesButton = this.didClickPackagesButton.bind(this)
this.didClickThemesButton = this.didClickThemesButton.bind(this)
this.didClickStylingButton = this.didClickStylingButton.bind(this)
Expand Down Expand Up @@ -82,6 +83,25 @@ export default class GuideView {
</div>
</details>

<details className='welcome-card' {...this.getSectionProps('teletype')}>
<summary className='welcome-summary icon icon-radio-tower'>
Real time collaboration with <span class='welcome-highlight'>Teletype</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about rephrasing this as a call-to-action? Maybe something like:

Collaborate in real time with Teletype

That would make it more consistent with most of the other sections (e.g., "Install a Package", "Hack on the Init Script", etc.). At the moment, the "Version control with Git and GitHub" item is the only one that doesn't use a call-to-action phrasing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I will update the title and merge this pull-request. Thanks, @jasonrudolph!

</summary>
<div className='welcome-detail'>
<p>
<img className='welcome-img' src='atom://welcome/assets/code.svg' />
</p>
<p>
Share your workspace with team members and collaborate on code in real time.
</p>
<p>
<button onclick={this.didClickTeletypeButton} className='btn btn-primary inline-block'>
Install Teletype for Atom
</button>
</p>
</div>
</details>

<details className='welcome-card' {...this.getSectionProps('packages')}>
<summary className='welcome-summary icon icon-package'>
Install a <span className='welcome-highlight'>Package</span>
Expand Down Expand Up @@ -333,6 +353,11 @@ export default class GuideView {
atom.workspace.open('atom://.atom/snippets', {split: 'left'})
}

didClickTeletypeButton () {
this.props.reporterProxy.sendEvent('clicked-teletype-cta')
atom.workspace.open('atom://config/packages/teletype', {split: 'left'})
}

didExpandOrCollapseSection (event) {
const sectionName = event.currentTarget.closest('details').dataset.section
const action = event.currentTarget.hasAttribute('open') ? 'collapse' : 'expand'
Expand Down