Fixes issue #70 #86
Merged
Fixes issue #70 #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The deploy step in the GitHub pages workflow is only executed if a reviewer approves the changes of the PR.
DanielKotik
force-pushed
the
fix-issue-70
branch
from
1780a1a
to
8f8ae6e
Compare
DanielKotik
force-pushed
the
fix-issue-70
branch
from
8f8ae6e
to
dca65b4
Compare
With this setup we circumvent the limitations of `GITHUB_TOKEN`. Forks can now deploy to GH pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partly solves issue #70. These changes prevent the "deploy to GitHub pages" step from being executed only by just opening a PR. For that we add a new trigger event which executes the workflow in
gh-pages.ymlagain when a review for the PR is submitted/edited. This allows for filtering the "deploy to GitHub pages" step - it will only run when a reviewer approves the changes made by the PR. Unforunately, due to missing write permissions of theGITHUB_TOKEN, the deployment will still fail. Although I explicitly grant permisssion within the workflow and adjust the permissions on organisation level, this is still an open question.