Fix issue #97 (overwriting data storage folders with joblib)
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielKotik
requested changes
Nov 15, 2021
atoMEC/numerov.py
Outdated
Comment on lines
159
to
161
| joblib_folder = "".join( | ||
| random.choices(string.ascii_uppercase + string.digits, k=30) | ||
| ) |
There was a problem hiding this comment.
Although very unlikely, but if a joblib_folder already exists it will still be (silently) overwritten. I would suggest
while True:
try:
joblib_folder = "".join(random.choices(string.ascii_uppercase + string.digits, k=30))
os.mkdir(joblib_folder)
break
except FileExistsError as e:
print(e)There was a problem hiding this comment.
I've made the suggested change
DanielKotik
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a fix for issue #97. The data folder from which
joblibreads large arrays is created with a random name so that when multiple jobs are submitted from the same directory, the data written in one job does not overwrite the data in another.