Skip to content

Commit

Permalink
Use the reversed rounding for the base currency
Browse files Browse the repository at this point in the history
  • Loading branch information
skubarenko committed Aug 17, 2022
1 parent f305a61 commit 60cd823
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion src/exchange/helpers/symbolsHelper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const convertSymbolToFromToCurrenciesPair = (
preparedBaseCurrencyAmount = converters.toFixedBigNumber(
preparedQuoteCurrencyPrice.multipliedBy(preparedQuoteCurrencyAmount),
symbol.decimals.baseCurrency,
isBuySide ? BigNumber.ROUND_FLOOR : BigNumber.ROUND_CEIL
isBuySide ? BigNumber.ROUND_CEIL : BigNumber.ROUND_FLOOR
);
}
else {
Expand Down
2 changes: 1 addition & 1 deletion tests/clients/testCases/validOrderTestCases.ts
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ const validOrderTestCases: ReadonlyArray<readonly [
timeStamp: new Date('2022-07-20T18:28:14.521308Z'),
from: {
currencyId: 'ETH',
amount: new BigNumber(0.009999999),
amount: new BigNumber(0.01),
price: new BigNumber(920.085936026)
},
to: {
Expand Down
2 changes: 1 addition & 1 deletion tests/clients/testCases/validSwapTestCases.ts
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ const validSwapTestCases: ReadonlyArray<readonly [
},
from: {
currencyId: 'ETH',
amount: new BigNumber(0.009999999),
amount: new BigNumber(0.01),
price: new BigNumber(920.085936026)
},
to: {
Expand Down
2 changes: 1 addition & 1 deletion tests/clients/testCases/validWsOrderUpdatedTestCases.ts
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const validWsOrderUpdatedTestCases: ReadonlyArray<readonly [
timeStamp: new Date('2022-07-20T18:28:14.521308Z'),
from: {
currencyId: 'ETH',
amount: new BigNumber(0.009999999),
amount: new BigNumber(0.01),
price: new BigNumber(920.085936026)
},
to: {
Expand Down
2 changes: 1 addition & 1 deletion tests/clients/testCases/validWsSwapUpdatedTestCases.ts
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ const validWsSwapUpdatedTestCases: ReadonlyArray<readonly [
},
from: {
currencyId: 'ETH',
amount: new BigNumber(0.009999999),
amount: new BigNumber(0.01),
price: new BigNumber(920.085936026)
},
to: {
Expand Down
6 changes: 3 additions & 3 deletions tests/exchange/testCases/validGetOrderPreviewTestCases.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ const validGetOrderPreviewTestCases: ReadonlyArray<[
},
to: {
currencyId: 'ETH',
amount: new BigNumber('0.038947563'),
amount: new BigNumber('0.038947562'),
price: new BigNumber('911.067096447')
}
},
Expand All @@ -138,7 +138,7 @@ const validGetOrderPreviewTestCases: ReadonlyArray<[
},
to: {
currencyId: 'ETH',
amount: new BigNumber('0.038947563'),
amount: new BigNumber('0.038947562'),
price: new BigNumber('911.067096447')
}
},
Expand All @@ -164,7 +164,7 @@ const validGetOrderPreviewTestCases: ReadonlyArray<[
},
to: {
currencyId: 'ETH',
amount: new BigNumber('0.062699506'),
amount: new BigNumber('0.062699505'),
price: new BigNumber('911.067096447')
}
},
Expand Down

0 comments on commit 60cd823

Please sign in to comment.